https://codereview.chromium.org/118553003/diff/170001/test/mjsunit/harmony/symbols.js
File test/mjsunit/harmony/symbols.js (right):
https://codereview.chromium.org/118553003/diff/170001/test/mjsunit/harmony/symbols.js#newcode172
test/mjsunit/harmony/symbols.js:172: assertEquals(Object(symbols[i]),
Object(symbols[i]))
On 2014/02/01 13:58:10, sof wrote:
On 2014/02/01 01:33:10, arv wrote:
> This looks strange. If symbol[i] is a symbol (not a symbol wrapper)
then this
> should be false. Are all elements in symbols wrappers? It does not
seem like
> that is the case on line 49.
They're all Symbol values. This is an equals check, not same, so why
should
deepObjectEquals() return false? (Perhaps not a very interesting to
test to add,
I can remove.)
If all elements in symbols are symbol values (not symbol wrapper
objects) this should be assertNotEquals since a new wrapper is always
created when you do Object(value).
https://codereview.chromium.org/118553003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
