Bonus points if you make this non-MIPS-specific: Assume there are
commits "MIPS:
Port r123", "FOOBAR: Port r123", etc. :-)
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh
File tools/merge-to-branch.sh (right):
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh#newcode144
tools/merge-to-branch.sh:144: MIPS_GIT_HASH=$(git log svn/bleeding_edge
-1 --format=%H --grep="Port r$REVISION")
On 2014/02/05 11:10:52, Michael Achenbach wrote:
Can svn/bleeding_edge be left out here?
Definitely not. "git checkout -b" above branches from the branch we're
merging to, so "git log" alone would show the history of that branch.
I'd like 80col lines, though, here and below :-)
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh#newcode145
tools/merge-to-branch.sh:145: if [ "$MIPS_GIT_HASH" != "" ] ; then
On 2014/02/05 11:10:52, Michael Achenbach wrote:
I'm not a bash expert. Is this equivalent? Then prefer the latter for
consistency:
if [ "$MIPS_GIT_HASH" != "" ] ; then
if [ -n "$MIPS_GIT_HASH" ] ; then
+1. AFAIK Bash doesn't handle empty strings very well, so please use the
-n/-z tests.
https://codereview.chromium.org/152343011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
