Thank you for the review and your comments!
I've uploaded a more sophisticated version, which is MIPS-independent.
It can also handle the case, when more port exists for a single commit (for
example if the A commit has a B FOO port and a C BAR port).
PTAL.
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh
File tools/merge-to-branch.sh (right):
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh#newcode145
tools/merge-to-branch.sh:145: if [ "$MIPS_GIT_HASH" != "" ] ; then
On 2014/02/05 12:04:13, Jakob wrote:
On 2014/02/05 11:10:52, Michael Achenbach wrote:
> I'm not a bash expert. Is this equivalent? Then prefer the latter
for
> consistency:
> if [ "$MIPS_GIT_HASH" != "" ] ; then
> if [ -n "$MIPS_GIT_HASH" ] ; then
+1. AFAIK Bash doesn't handle empty strings very well, so please use
the -n/-z
tests.
Done.
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh#newcode148
tools/merge-to-branch.sh:148:
FULL_REVISION_LIST=("${FULL_REVISION_LIST[@]}" "$REVISION"
"$MIPS_SVN_REVISION")
On 2014/02/05 11:10:52, Michael Achenbach wrote:
What is with revisions where no MIPS port exists, are they skipped
now? E.g.
consider 3 revision to be merged out of which two have a MIPS port.
Where is the
third added to FULL_REVISION_LIST?
Auch. Thanks for pointing this out! Done.
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh#newcode179
tools/merge-to-branch.sh:179: for REVISION in $FULL_REVISION_LIST ; do
On 2014/02/05 11:10:52, Michael Achenbach wrote:
All state that needs to be transferred from one step to the next
should be
persisted. E.g. if "git svn find-rev" times out in this step, the
script should
be callable with the -s option in the same step, where it failed. Look
below how
REVISION_LIST is persisted.
Done.
https://codereview.chromium.org/152343011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
