I don't really like the fact that you have to untag/retag the index in
fullcodegen. IMO it would be better to add an extra argument to the
MacroAssembler function to specify whether the index is tag or untagged and
make
the function able to cope with both situations. What do you think?
https://codereview.chromium.org/141713009/diff/1/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/141713009/diff/1/src/a64/macro-assembler-a64.cc#newcode3645
src/a64/macro-assembler-a64.cc:3645: Cmp(index, scratch);
You can avoid to Tag/Untag the index by untagging scratch here just for
the Cmp. Here it will be something similar to:
Cmp(index, Operand::UntagSmi(scratch))
It will make use of shifted register and will avoid adding extra
instructions.
https://codereview.chromium.org/141713009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
