https://codereview.chromium.org/141713009/diff/100001/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/141713009/diff/100001/src/a64/macro-assembler-a64.cc#newcode3648
src/a64/macro-assembler-a64.cc:3648: Cmp(index,
Operand(Smi::FromInt(0)));
On 2014/02/06 15:48:13, baptiste.afsa1 wrote:
Although it will work, it doesn't really make sense to compare with
Smi::FromInt(0) when the index is not a SMI.
Maybe you should compare with 0 and assert that Smi::FromInt(0) == 0
with a
comment explaining what's going on here.
I added assert, but didn't add comment since the assert and the code
above makes it clear.
https://codereview.chromium.org/141713009/diff/100001/src/a64/macro-assembler-a64.h
File src/a64/macro-assembler-a64.h (right):
https://codereview.chromium.org/141713009/diff/100001/src/a64/macro-assembler-a64.h#newcode1479
src/a64/macro-assembler-a64.h:1479: bool index_is_smi,
On 2014/02/06 15:48:13, baptiste.afsa1 wrote:
Usually v8 functions which use that kind of trick use an enum to
specify the
"mode" instead of a bool. Maybe you should do the same here.
Done.
https://codereview.chromium.org/141713009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
