On 2014/02/10 08:11:13, Dmitry Lomov (chromium) wrote:
On 2014/02/10 07:52:42, haitao.feng wrote:
> This refactoring is needed when we implemented experimental Float32x4Array
and
> Int32x4Array (https://github.com/johnmccutchan/ecmascript_simd). Otherwise
we
> need to copy the TYPED_ARRAY_CONSTRUCTOR macro definition inside an
experimental
> simd128.js file.

I do not like polluting global macros space with typed-array-related macros. The better solution would be to move Float32x4Array into typedarray.js in simd
patch.

In any case, since this patch will not affect main-line V8 in foreseeable
future, we should not put it into bleeding_edge.

I agree.

https://codereview.chromium.org/158643003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to