On 2014/02/11 03:11:19, haitao.feng wrote:
> I do not like polluting global macros space with typed-array-related
macros.
> The better solution would be to move Float32x4Array into typedarray.js
in
simd
> patch.
The typedarray.js is a builtin library but simd is an experimental
library.
The
simd stuff should not be inside the snapshot. The problem occurs for any
experimental feature which extends a builtin feature with inline macro
definitions.
Tough. Polluting macros.py with typed array definitions is not the answer
either.
Here is an idea - provide for inclusion of one file into another, just for
macros, something like:
use macros from 'typedarray.js';
Sounds appropriate, since simd.js in your patch is an experimental
extension of
typedarray.js - seems like it should be able to use macros from the latter.
Other idea is to have typedarray-macros.py, just for these two files.
Either way, still does not belong on bleeding_edge.
https://codereview.chromium.org/158643003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
