https://codereview.chromium.org/131383004/diff/1/build/toolchain.gypi
File build/toolchain.gypi (right):
https://codereview.chromium.org/131383004/diff/1/build/toolchain.gypi#newcode523
build/toolchain.gypi:523: # Hide some GCC 4.8 warnings:
Yes remove.
On 2014/02/11 17:24:26, ulan wrote:
Remove before merge?
https://codereview.chromium.org/131383004/diff/1/build/toolchain.gypi#newcode628
build/toolchain.gypi:628: # Hide some GCC 4.8 warnings:
Yes remove
On 2014/02/11 17:24:26, ulan wrote:
Remove before merge?
https://codereview.chromium.org/131383004/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/131383004/diff/1/src/compiler.cc#newcode310
src/compiler.cc:310: if (FLAG_trace_opt) {
Yes remove.
On 2014/02/11 17:24:26, ulan wrote:
Remove before landing?
https://codereview.chromium.org/131383004/diff/1/test/mjsunit/div-mod.js
File test/mjsunit/div-mod.js (right):
https://codereview.chromium.org/131383004/diff/1/test/mjsunit/div-mod.js#newcode130
test/mjsunit/div-mod.js:130: // TODO(all): due to a bug in fmod(),
modulos involving denormals
Yes but maybe leave a comment that those tests may fail on older libc?
On 2014/02/11 17:24:26, ulan wrote:
Remove before merge?
https://codereview.chromium.org/131383004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
