https://codereview.chromium.org/131383004/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/131383004/diff/1/src/bootstrapper.cc#newcode2640
src/bootstrapper.cc:2640: if (!FLAG_disable_native_files) {
I believe this was to make it easier to start the port. You can remove.
On 2014/02/11 18:31:06, rmcilroy wrote:
Is this a general bug-fix or specific for A64 or something left over
from
testing?
https://codereview.chromium.org/131383004/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/131383004/diff/1/src/builtins.cc#newcode1631
src/builtins.cc:1631: // we can generate a lot of debug code on A64.
Yes, when in debug we generate a fair amount of extra code.
On 2014/02/11 18:31:06, rmcilroy wrote:
Is this still required?
https://codereview.chromium.org/131383004/diff/1/src/checks.h
File src/checks.h (right):
https://codereview.chromium.org/131383004/diff/1/src/checks.h#newcode58
src/checks.h:58:
making them non a64 specific sounds good to me.
The simulator enabled ones (ASM_LOCATION and so on) are particularly
useful when developing so would be good to keep them.
On 2014/02/11 18:31:06, rmcilroy wrote:
Could we remove these now? There is only one TODO_UNIMPLEMENTED left
in the
simulator-a64 and one ASM_UNIMPLEMENTED in lithium-codegen-a64.cc.
Otherwise,
could we make them non-a64 specific?
https://codereview.chromium.org/131383004/diff/1/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/131383004/diff/1/src/code-stubs.h#newcode110
src/code-stubs.h:110: #elif V8_TARGET_ARCH_A64
Yes they can be consolidated.
On 2014/02/11 18:31:06, rmcilroy wrote:
These seem to be the same, could we merge into the previous ifdef and
make it
#if defined(V8_TARGET_ARCH_ARM) || defined(V8_TARGET_ARCH_A64).
https://codereview.chromium.org/131383004/diff/1/test/message/message.status
File test/message/message.status (right):
https://codereview.chromium.org/131383004/diff/1/test/message/message.status#newcode35
test/message/message.status:35: ['arch == a64', {
Yes.
On 2014/02/11 18:31:06, rmcilroy wrote:
Can we remove this?
https://codereview.chromium.org/131383004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
