https://codereview.chromium.org/154283002/diff/180001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/154283002/diff/180001/include/v8.h#newcode5421
include/v8.h:5421: static const int kEmptyStringRootIndex = 148;
I didn't, but I have now, although I have no idea what grokdump is and
when I need to run it. The changes now included in this patch now
clearly exceed the scope of this patch. I'm assuming that's ok?
On 2014/02/11 07:47:13, dcarney wrote:
did you run make grokdump and commit the changes?
https://codereview.chromium.org/154283002/diff/180001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/154283002/diff/180001/src/api.cc#newcode6315
src/api.cc:6315: ExternalMicrotaskCallback callback) {
On 2014/02/11 07:47:13, dcarney wrote:
No need for a new ExternalMicrotaskCallback type: just use
Handle<Function> here
as the second argument.
Also, I don't see a reason to call all these things ExternalMicrotask
everywhere, just Microtask is maybe better.
Done.
https://codereview.chromium.org/154283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
