lgtm, small nit
https://codereview.chromium.org/154283002/diff/180001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/154283002/diff/180001/include/v8.h#newcode5421
include/v8.h:5421: static const int kEmptyStringRootIndex = 148;
On 2014/02/11 20:37:43, rafaelw wrote:
I didn't, but I have now, although I have no idea what grokdump is and
when I
need to run it. The changes now included in this patch now clearly
exceed the
scope of this patch. I'm assuming that's ok?
any time you add or remove an instancetype or add or remove heap roots,
it must be run, the changes that it applies are intended
https://codereview.chromium.org/154283002/diff/260001/src/v8.cc
File src/v8.cc (right):
https://codereview.chromium.org/154283002/diff/260001/src/v8.cc#newcode185
src/v8.cc:185: void V8::EnqueueMicrotask(Isolate* isolate,
Handle<Object> microtask) {
this function seems kinds of pointless now, maybe delete
https://codereview.chromium.org/154283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
