More comments.
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc#newcode212
src/hydrogen-check-elimination.cc:212: // If the other state is empty,
simply reset.
Reset();
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc#newcode443
src/hydrogen-check-elimination.cc:443: void Kill() {
KillNonStableEntries(); ?
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc#newcode638
src/hydrogen-check-elimination.cc:638: bool requires_reset_ : 1;
Consider replacing these flags with GVNFlagSet as was recently done in
load elimination (r19322).
https://codereview.chromium.org/153823003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
