Addressed comments
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc#newcode212
src/hydrogen-check-elimination.cc:212: // If the other state is empty,
simply reset.
On 2014/02/12 12:58:20, Igor Sheludko wrote:
Reset();
Done.
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc#newcode443
src/hydrogen-check-elimination.cc:443: void Kill() {
On 2014/02/12 12:58:20, Igor Sheludko wrote:
KillNonStableEntries(); ?
Done.
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc#newcode638
src/hydrogen-check-elimination.cc:638: bool requires_reset_ : 1;
On 2014/02/12 12:58:20, Igor Sheludko wrote:
Consider replacing these flags with GVNFlagSet as was recently done in
load
elimination (r19322).
Done.
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-instructions.h#newcode2707
src/hydrogen-instructions.h:2707: }
I think it's a fine approximation for now. We can try to optimize later
when it becomes necessary.
On 2014/02/12 11:39:40, Igor Sheludko wrote:
If all but the last map we are adding are stable then we will add
dependency
even if the instruction is not stable. Is it ok?
https://codereview.chromium.org/153823003/diff/60001/test/cctest/test-deoptimization.cc
File test/cctest/test-deoptimization.cc (right):
https://codereview.chromium.org/153823003/diff/60001/test/cctest/test-deoptimization.cc#newcode616
test/cctest/test-deoptimization.cc:616: // CHECK_EQ(0,
Deoptimizer::GetDeoptimizedCodeCount(CcTest::i_isolate()));
On 2014/02/12 11:39:40, Igor Sheludko wrote:
What if we disable check elimination for this test instead of
commenting this?
Done.
https://codereview.chromium.org/153823003/diff/60001/test/cctest/test-deoptimization.cc#newcode698
test/cctest/test-deoptimization.cc:698: // CHECK_EQ(0,
Deoptimizer::GetDeoptimizedCodeCount(CcTest::i_isolate()));
On 2014/02/12 11:39:40, Igor Sheludko wrote:
Same as above.
Done.
https://codereview.chromium.org/153823003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
