ptal
https://codereview.chromium.org/163593002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/163593002/diff/1/src/heap-snapshot-generator.cc#newcode1460
src/heap-snapshot-generator.cc:1460: int entry, JSArrayBuffer* array) {
On 2014/02/13 14:28:01, Dmitry Lomov (chromium) wrote:
Nit: array -> buffer
Done.
https://codereview.chromium.org/163593002/diff/1/src/heap-snapshot-generator.cc#newcode1467
src/heap-snapshot-generator.cc:1467: int data_size =
NumberToInt32(array->byte_length());
On 2014/02/13 14:28:01, Dmitry Lomov (chromium) wrote:
ArrayBuffer's byte length should be size_t, not int. Use
NumberToSize/TryNumberToSize here.
I thought about it, but I found that [currently] ArrayBuffer in JS does
not support sizes larger than int32.
Anyway to be on the safe side, I added an ASSERT.
https://codereview.chromium.org/163593002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
