On 2014/02/13 15:20:45, Dmitry Lomov (chromium) wrote:
lgtm with a nit
Also, I do recommend changing type size in SnapshotEntry to size_t - not
necessarily in this CL.
That's among our plans. We have recently moved snapshot storage to the
client
side, so we're not limited in snapshot memory in v8 anymore, and can afford
increasing heap entry size.
V8 code supports allocating >2GB ArrayBuffers, even though currently Blink
limits that to <1GB (just try it in ia32 d8: var x = new
ArrayBuffer(0x80000000))
https://codereview.chromium.org/163593002/diff/70001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/163593002/diff/70001/src/heap-snapshot-generator.cc#newcode1468
src/heap-snapshot-generator.cc:1468: ASSERT(data_size <= kMaxInt);
Use CHECK instead of ASSERT to crash in Release mode as well.
https://codereview.chromium.org/163593002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
