LGTM
Thanks for taking care of this.
https://codereview.chromium.org/118553003/diff/620001/test/mjsunit/harmony/symbols.js
File test/mjsunit/harmony/symbols.js (right):
https://codereview.chromium.org/118553003/diff/620001/test/mjsunit/harmony/symbols.js#newcode55
test/mjsunit/harmony/symbols.js:55: assertThrows(function () {
Symbol(Symbol()) }, TypeError)
These two assertThrows can be done once outside the outer loop. No need
to test them 10 times each.
https://codereview.chromium.org/118553003/diff/620001/test/mjsunit/harmony/symbols.js#newcode116
test/mjsunit/harmony/symbols.js:116: assertThrows(function() {
(Symbol(symbols[i])).toString() }, TypeError)
Doesn't this one throw due to Symbol(symbols[i]) and not due to the
toString?
https://codereview.chromium.org/118553003/diff/620001/test/mjsunit/harmony/symbols.js#newcode171
test/mjsunit/harmony/symbols.js:171: assertTrue(Object(symbols[i]) !==
Object(symbols[i]))
assertFalse(Object(symbols[i]) === Object(symbols[i]))
for consistency?
https://codereview.chromium.org/118553003/diff/620001/test/mjsunit/harmony/symbols.js#newcode229
test/mjsunit/harmony/symbols.js:229: Symbol.prototype.getThisProto =
function () { return Object.getPrototypeOf(this); }
long line
https://codereview.chromium.org/118553003/diff/620001/test/mjsunit/harmony/symbols.js#newcode229
test/mjsunit/harmony/symbols.js:229: Symbol.prototype.getThisProto =
function () { return Object.getPrototypeOf(this); }
too many spaces. But after line wrapping it should be.
Symbol.prototype.getThisProto = function() {
return Object.getPrototypeOf(this)
}
https://codereview.chromium.org/118553003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
