LGTM, will land tomorrow
https://codereview.chromium.org/118553003/diff/550001/src/runtime.h
File src/runtime.h (right):
https://codereview.chromium.org/118553003/diff/550001/src/runtime.h#newcode317
src/runtime.h:317: F(NewSymbolWrapper, 1, 1) \
On 2014/02/14 14:20:02, sof wrote:
On 2014/02/14 10:55:30, rossberg wrote:
> Seems like this runtime function has become obsolete now.
I don't understand; it's called by ToObject() to create a wrapper
object.
Ah, sorry, I missed that. But can't we use Object(symbol) in that place?
Or would that be circular somehow?
https://codereview.chromium.org/118553003/diff/550001/test/mjsunit/harmony/symbols.js
File test/mjsunit/harmony/symbols.js (right):
https://codereview.chromium.org/118553003/diff/550001/test/mjsunit/harmony/symbols.js#newcode126
test/mjsunit/harmony/symbols.js:126: checkToString(function() { return
Symbol.prototype.toString.call(symbols[i]) })
On 2014/02/14 14:20:02, sof wrote:
On 2014/02/14 10:55:30, rossberg wrote:
> Nit: line length
Tweaked, but isn't it < 80?
Looked like 83 in the code review...
https://codereview.chromium.org/118553003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
