https://chromiumcodereview.appspot.com/166383002/diff/60001/src/api.cc
File src/api.cc (right):
https://chromiumcodereview.appspot.com/166383002/diff/60001/src/api.cc#newcode6975
src/api.cc:6975: CHECK(size <= static_cast<size_t>(internal::kMaxInt));
On 2014/02/18 08:03:25, yurys wrote:
As I understand this check may well fail which is the reason you
introduce
GetShallowSize. Should we remove it?
I introduced GetShallowSize to avoid breaking the API.
AFAIK with Blink client there's no objects of size greater than 2GB, so
this check should never fail. For other clients I think it's better to
fail rather than return a bogus value. Nevertheless this function is
deprecated and will be removed.
https://chromiumcodereview.appspot.com/166383002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
