lgtm (a small warning re windows build)
https://chromiumcodereview.appspot.com/166383002/diff/60001/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
https://chromiumcodereview.appspot.com/166383002/diff/60001/test/cctest/test-heap-profiler.cc#newcode237
test/cctest/test-heap-profiler.cc:237: CHECK_NE(0, x->GetShallowSize());
IIRC, you'll need static_cast<int> to compile on Windows - make sure you
run on a try bot before landing (also below)
https://chromiumcodereview.appspot.com/166383002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
