Reviewers: jochen, ulan,
Message:
Committed patchset #1 manually as r19472 (presubmit successful).
Description:
A64: Replace a Cmp/Branch sequence by a conditional compare.
[email protected], [email protected]
Committed: https://code.google.com/p/v8/source/detail?r=19472
Please review this at https://codereview.chromium.org/169403003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -4 lines):
M src/a64/regexp-macro-assembler-a64.cc
Index: src/a64/regexp-macro-assembler-a64.cc
diff --git a/src/a64/regexp-macro-assembler-a64.cc
b/src/a64/regexp-macro-assembler-a64.cc
index
00558c017b9cecf82b67706ce40a95abbf021930..b162b38bde686c0cb93de9f29d6155c9e6642d1f
100644
--- a/src/a64/regexp-macro-assembler-a64.cc
+++ b/src/a64/regexp-macro-assembler-a64.cc
@@ -363,11 +363,9 @@ void
RegExpMacroAssemblerA64::CheckNotBackReferenceIgnoreCase(
__ B(ls, &loop_check); // In range 'a'-'z'.
// Latin-1: Check for values in range [224,254] but not 247.
__ Sub(w10, w10, 224 - 'a');
- // TODO(jbramley): Use Ccmp here.
__ Cmp(w10, 254 - 224);
- __ B(hi, &fail); // Weren't Latin-1 letters.
- __ Cmp(w10, 247 - 224); // Check for 247.
- __ B(eq, &fail);
+ __ Ccmp(w10, 247 - 224, ZFlag, ls); // Check for 247.
+ __ B(eq, &fail); // Weren't Latin-1 letters.
__ Bind(&loop_check);
__ Cmp(capture_start_address, capture_end_addresss);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
