Revision: 19472
Author:   [email protected]
Date:     Wed Feb 19 09:37:07 2014 UTC
Log:      A64: Replace a Cmp/Branch sequence by a conditional compare.

[email protected], [email protected]

Review URL: https://codereview.chromium.org/169403003
http://code.google.com/p/v8/source/detail?r=19472

Modified:
 /branches/bleeding_edge/src/a64/regexp-macro-assembler-a64.cc

=======================================
--- /branches/bleeding_edge/src/a64/regexp-macro-assembler-a64.cc Wed Feb 12 09:19:30 2014 UTC +++ /branches/bleeding_edge/src/a64/regexp-macro-assembler-a64.cc Wed Feb 19 09:37:07 2014 UTC
@@ -363,11 +363,9 @@
     __ B(ls, &loop_check);  // In range 'a'-'z'.
     // Latin-1: Check for values in range [224,254] but not 247.
     __ Sub(w10, w10, 224 - 'a');
-    // TODO(jbramley): Use Ccmp here.
     __ Cmp(w10, 254 - 224);
-    __ B(hi, &fail);  // Weren't Latin-1 letters.
-    __ Cmp(w10, 247 - 224);  // Check for 247.
-    __ B(eq, &fail);
+    __ Ccmp(w10, 247 - 224, ZFlag, ls);  // Check for 247.
+    __ B(eq, &fail);  // Weren't Latin-1 letters.

     __ Bind(&loop_check);
     __ Cmp(capture_start_address, capture_end_addresss);

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to