Reviewers: Michael Starzinger,
Message:
Michael: This is what we talked about when I was in Munich - avoiding
having to
"fake-up" RelocInfo objects for UpdateSlots(). This is required for the OOL
constant pool work, but should benefit Arm's current inline constant pool
too.
PTAL.
Description:
Special case the recording of constant pool entries in the slot buffer.
This CL enables RelocInfo pointers which live in the constant pool to be
treated
as normal pointers by the slot buffer, avoiding the requirement of creating
fake
RelocInfo objects during UpdateSlots() in order to update these slots. This
is possible because constant pool entries are just pointers and don't
require
the RelocInfo machinary to be updated.
EmbeddedObject constant pool entries can be added untyped to the slot
buffer,
while code targets are still typed in order to correctly update the target
address based on the relocated code object.
Note: this is required in order to enable OOL constant pool support on Arm,
but
should be benifitial for the current inline constant pool used by Arm code.
Please review this at https://codereview.chromium.org/179813005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+148, -13 lines):
M src/a64/assembler-a64-inl.h
M src/a64/assembler-a64.cc
M src/arm/assembler-arm-inl.h
M src/arm/assembler-arm.cc
M src/assembler.h
M src/ia32/assembler-ia32-inl.h
M src/ia32/assembler-ia32.cc
M src/liveedit.cc
M src/mark-compact.h
M src/mark-compact.cc
M src/mips/assembler-mips-inl.h
M src/mips/assembler-mips.cc
M src/objects.h
M src/objects.cc
M src/serialize.h
M src/serialize.cc
M src/x64/assembler-x64-inl.h
M src/x64/assembler-x64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
