Reviewers: Yang,
Message:
PTAL
https://codereview.chromium.org/180053003/diff/1/test/mjsunit/compiler/concurrent-invalidate-transition-map.js
File test/mjsunit/compiler/concurrent-invalidate-transition-map.js
(right):
https://codereview.chromium.org/180053003/diff/1/test/mjsunit/compiler/concurrent-invalidate-transition-map.js#newcode47
test/mjsunit/compiler/concurrent-invalidate-transition-map.js:47:
add_field(obj);
If GC happens between the calls and there is no live instance of
new_object then then transition in add_field will be collected, so on
the next call to add_field the obj.c IC will not turn MONOMORPHIC.
Description:
Fix mjsunit/compiler/concurrent-invalidate-transition-map.js test.
BUG=v8:3156
LOG=N
Please review this at https://codereview.chromium.org/180053003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -5 lines):
M test/mjsunit/compiler/concurrent-invalidate-transition-map.js
M test/mjsunit/mjsunit.status
Index: test/mjsunit/compiler/concurrent-invalidate-transition-map.js
diff --git a/test/mjsunit/compiler/concurrent-invalidate-transition-map.js
b/test/mjsunit/compiler/concurrent-invalidate-transition-map.js
index
2a20790eaaa03e693fcc32d977b7de49fb2907eb..3f66f9c4b2d5312f1b3244bf4edbd7413b9d8640
100644
--- a/test/mjsunit/compiler/concurrent-invalidate-transition-map.js
+++ b/test/mjsunit/compiler/concurrent-invalidate-transition-map.js
@@ -43,9 +43,9 @@ function new_object() {
function add_field(obj) {
obj.c = 3;
}
-
-add_field(new_object());
-add_field(new_object());
+var obj = new_object();
+add_field(obj);
+add_field(obj);
%OptimizeFunctionOnNextCall(add_field, "concurrent");
var o = new_object();
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
4dcf7eec63ef7d3339d9c94756d39b5639a1c9ae..f1392631b8cdaedd74dcab0e2b17e0e8644ddb72
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -176,8 +176,6 @@
# BUG(v8:3147). It works on other architectures by accident.
'regress/regress-conditional-position': [FAIL],
- # BUG(v8:3156): Fails on gc stress bots.
- 'compiler/concurrent-invalidate-transition-map': [PASS, ['gc_stress ==
True', FAIL]],
}], # 'arch == a64'
['arch == a64 and mode == debug and simulator_run == True', {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
