Sorry - I didn't realize that you had submitted another patch set and was
waiting for that. Please ping me in the future if I'm taking too long.
One final comment in PrintF but otherwise looks good.
https://codereview.chromium.org/164793003/diff/190001/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/164793003/diff/190001/src/a64/macro-assembler-a64.cc#newcode4993
src/a64/macro-assembler-a64.cc:4993:
FPTmpList()->Combine(kCallerSavedFP);
Do we really need all these registers as temps? Seems quite hacky to
modify the TmpList manually here and rely on the UseScratchRegisterScope
to restore it. Maybe you could just use:
Register tmp = GetAllocatableRegisterThatIsNotOneOf(arg0..arg3)?
Not sure if any of these other macroassembler calls could use tmp
registers internally as well though?
https://codereview.chromium.org/164793003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
