https://codereview.chromium.org/164793003/diff/190001/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/164793003/diff/190001/src/a64/macro-assembler-a64.cc#newcode4993
src/a64/macro-assembler-a64.cc:4993:
FPTmpList()->Combine(kCallerSavedFP);
On 2014/02/27 11:17:32, rmcilroy wrote:
Do we really need all these registers as temps? Seems quite hacky to
modify the
TmpList manually here and rely on the UseScratchRegisterScope to
restore it.
No, it doesn't need them, but it's easier to provide them all than to
select a couple from the list. We have to preserve all caller-saved
registers for the call anyway, so they'll all potentially be clobbered.
This should have been temps.Include() rather than a TmpList() hack, and
I would have changed it had I not removed Include().
Maybe you could just use:
Register tmp = GetAllocatableRegisterThatIsNotOneOf(arg0..arg3)?
GetAllocatableRegisterThatIsNotOneOf doesn't work because the list of
allocatable scratch registers includes some callee-saved registers.
Not sure if any of these other macroassembler calls could use tmp
registers
internally as well though?
Theoretically they might, but in practice, I think the only one here
that uses scratch registers is PrintfNoPreserve.
https://codereview.chromium.org/164793003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
