Seems to be OK, just 1 remark and 1 nit so far.
https://codereview.chromium.org/178583006/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/178583006/diff/1/src/full-codegen.cc#newcode957
src/full-codegen.cc:957: masm()->CallRuntime(Runtime::kDoubleHi, 1);
Hopefully the usual benchmarks will not force us to do this directly in
an architecture-dependent way. Calls into the runtime are costly and if
we run full code "long" enough... :-/
https://codereview.chromium.org/178583006/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/178583006/diff/1/src/runtime.cc#newcode7687
src/runtime.cc:7687: static_cast<int32_t>(double_to_uint64(x) &
0xffffffff));
Add an unsigned suffix 'u' to the hexadecimal constant, otherwise it's
far from obvious that things are correct here.
https://codereview.chromium.org/178583006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
