On 2014/03/05 08:00:52, Sven Panne wrote:
LGTM with one (big) nit.
https://codereview.chromium.org/178583006/diff/20001/test/mjsunit/double-intrinsics.js
File test/mjsunit/double-intrinsics.js (right):
https://codereview.chromium.org/178583006/diff/20001/test/mjsunit/double-intrinsics.js#newcode30
test/mjsunit/double-intrinsics.js:30: %OptimizeFunctionOnNextCall(test);
Hmmm, this relies on inlining heuristics, otherwise we don't test what we
think
we test. It's assertDoubleBits which needs to be optimized.
Good point. I updated the test to not rely on inlining heuristics.
https://codereview.chromium.org/178583006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
