Thanks Jarin.
Thanks for the effort to fix this. I think we will need this covered by a
test
-
could you write a test that would fail without your patch? The test should
also
check that the desired exception is thrown on overflow.
I added a test that passes with my fix and fails without it when snapshots
are
disabled. Is there a ways to make this test run with snapshots disabled?
It seems that 'git diff' is confused by your bootstrapper.cc change - it
reports
that all lines in the file have been changed. I am not quite sure what
happened
there - perhaps the line endings do not match?
Yeah, not sure what happened, but it seems fixed now.
https://codereview.chromium.org/178073002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/178073002/diff/1/src/bootstrapper.cc#newcode1480
src/bootstrapper.cc:1480: if (check.WillOverflow(5000 *
sizeof(intptr_t))) {
Could you possibly create some constant with some descriptive name for the
buffer space?
Done.
https://codereview.chromium.org/178073002/diff/1/src/bootstrapper.cc#newcode2615
src/bootstrapper.cc:2615: if (check.WillOverflow(6000 *
sizeof(intptr_t))) {
Is there a reason why the magic constant differs from the one above?
These were empirical measures of how much stack is needed to get through
genesis. It turns out that the check in CompileNative is not useful because
a)
we have already entered the context and b) it's covered by the other check,
so I
remove it.
https://codereview.chromium.org/178073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
