Looks good, thanks.
https://codereview.chromium.org/178073002/diff/100001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/178073002/diff/100001/test/cctest/test-api.cc#newcode4989
test/cctest/test-api.cc:4989: void
APIStackOverflowNestedContextsHelper(bool is_bottom_call);
In v8, bools as arguments are normally frowned upon, enums are
preferred. However, since this is a test and the function decl, def and
use are close to each other, I think it is fine to leave as is.
https://codereview.chromium.org/178073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
