Reviewers: Sven Panne,

Message:
PTAL

Description:
ia32: Simplify inlined Smi code for SAR.

Please review this at https://codereview.chromium.org/188483002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+1, -2 lines):
  M src/ia32/full-codegen-ia32.cc


Index: src/ia32/full-codegen-ia32.cc
diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc
index 452cd08ee300b9809e303413cb39dccd8997573f..a6ec56b28b0a88ddff7f82a33ee98a1b5f88ee0a 100644
--- a/src/ia32/full-codegen-ia32.cc
+++ b/src/ia32/full-codegen-ia32.cc
@@ -2273,10 +2273,9 @@ void FullCodeGenerator::EmitInlineSmiBinaryOp(BinaryOperation* expr,

   switch (op) {
     case Token::SAR:
-      __ SmiUntag(eax);
       __ SmiUntag(ecx);
       __ sar_cl(eax);  // No checks of result necessary
-      __ SmiTag(eax);
+      __ and_(eax, Immediate(~kSmiTagMask));
       break;
     case Token::SHL: {
       Label result_ok;


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to