lgtm
https://codereview.chromium.org/190793002/diff/1/src/arm/assembler-arm.h
File src/arm/assembler-arm.h (right):
https://codereview.chromium.org/190793002/diff/1/src/arm/assembler-arm.h#newcode1579
src/arm/assembler-arm.h:1579: bool constant_pool_full_;
Could you add a comment explaining what constant_pool_full_ indicates?
https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):
https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.h#newcode1520
src/arm/macro-assembler-arm.h:1520: // manual or none frame type.
Did you mean to assert (type_ != StackFrame::MANUAL && type_ !=
StackFrame::NONE) here ?
https://codereview.chromium.org/190793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
