Thanks for the review. Comments addressed, PTAL
https://codereview.chromium.org/190793002/diff/1/src/arm/assembler-arm.h
File src/arm/assembler-arm.h (right):
https://codereview.chromium.org/190793002/diff/1/src/arm/assembler-arm.h#newcode1579
src/arm/assembler-arm.h:1579: bool constant_pool_full_;
On 2014/03/11 13:00:46, ulan wrote:
Could you add a comment explaining what constant_pool_full_ indicates?
Done (and for constant_pool_available)
https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.cc#newcode894
src/arm/macro-assembler-arm.cc:894: Code::kConstantPoolOffset -
Code::kHeaderSize - pc_offset() - 8;
On 2014/03/11 13:28:34, Rodolph Perfetta (ARM) wrote:
8 -> kPCReadOffset
Done.
https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):
https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.h#newcode1520
src/arm/macro-assembler-arm.h:1520: // manual or none frame type.
On 2014/03/11 13:00:46, ulan wrote:
Did you mean to assert (type_ != StackFrame::MANUAL && type_ !=
StackFrame::NONE) here ?
Ahh originally had this assert, but changed it to allow
StackFrame::Manual which set the CP to use this scoped object. Removed
the comment - thanks.
https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.h#newcode1531
src/arm/macro-assembler-arm.h:1531:
masm_->set_constant_pool_available(old_has_frame_);
On 2014/03/11 13:28:34, Rodolph Perfetta (ARM) wrote:
old_constant_pool_available_
Done thanks (I had this change, but it seemed to have ended up in the
wrong local branch / CL somehow...)
https://codereview.chromium.org/190793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
