Ulan just pointed me to https://codereview.chromium.org/169223004/, which
is a
subset of this CL. I think that the discussion about pointer aliasing is
right
in theory, but very wrong in practice: We do *exactly* the same casts in
the ARM
emulator for years, without any problems. Furthermore, we have *tons* of
casts
in v8 which are wrong under strict aliasing rules. (You can talk to Mads
about
this, he was very passionate about this ;-)
If there are no other (mostly theoretical) objections, I very much like to
land
this, because it saves a tremendous amount of developer/bot time with a tiny
change.
The *right* way of doing this is either throwing away the useless
distinction
between Instr and Instruction or make Instruction carry an Instr as a member
field, but this would probably be a bigger change. If somebody has time
left it
can be done, but in the meantime let's speed up our daily work.
https://codereview.chromium.org/195873009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
