Reviewers: ulan,
Message:
Committed patchset #1 manually as r19969 (presubmit successful).
Description:
Fix typo in r19923 (bounds check offset propagation)
BUG=chromium:352929
LOG=n
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=19969
Please review this at https://codereview.chromium.org/201303002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+34, -1 lines):
M src/hydrogen-bce.cc
A test/mjsunit/regress/regress-crbug-352929.js
Index: src/hydrogen-bce.cc
diff --git a/src/hydrogen-bce.cc b/src/hydrogen-bce.cc
index
cef1e0fca0b5974d9848ae64d8faaf111c31c885..c98a03cb5ab32d78b79a214c07edf5ecd2b1ee97
100644
--- a/src/hydrogen-bce.cc
+++ b/src/hydrogen-bce.cc
@@ -183,7 +183,7 @@ class BoundsCheckBbData: public ZoneObject {
lower_check_ = new_check;
} else {
TightenCheck(lower_check_, new_check);
- UpdateLowerOffsets(upper_check_, upper_offset_);
+ UpdateLowerOffsets(lower_check_, lower_offset_);
}
} else {
// Should never have called CoverCheck() in this case.
Index: test/mjsunit/regress/regress-crbug-352929.js
diff --git a/test/mjsunit/regress/regress-crbug-352929.js
b/test/mjsunit/regress/regress-crbug-352929.js
new file mode 100644
index
0000000000000000000000000000000000000000..a5872c12588d56696538d213ee53f20dcd7f54e0
--- /dev/null
+++ b/test/mjsunit/regress/regress-crbug-352929.js
@@ -0,0 +1,33 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+var dummy = new Int32Array(100);
+array = new Int32Array(100);
+var dummy2 = new Int32Array(100);
+
+array[-17] = 0;
+function fun(base,cond) {
+ array[base - 1] = 1;
+ array[base - 2] = 2;
+ if (cond) {
+ array[base - 4] = 3;
+ array[base - 5] = 4;
+ } else {
+ array[base - 6] = 5;
+ array[base - 100] = 777;
+ }
+}
+fun(5,true);
+fun(7,false);
+%OptimizeFunctionOnNextCall(fun);
+fun(7,false);
+
+for (var i = 0; i < dummy.length; i++) {
+ assertEquals(0, dummy[i]);
+}
+for (var i = 0; i < dummy2.length; i++) {
+ assertEquals(0, dummy2[i]);
+}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
