https://codereview.chromium.org/197473004/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/197473004/diff/1/src/heap.cc#newcode5042
src/heap.cc:5042: ASSERT(InNewSpace(src));
This ASSERT may be wrong here, but it should hold in factory.cc.
This is what can happen: The factory may trigger a gc which may move src
to old space.
In that case, you could just return the old src instead of allocating a
new one. WDYT?
https://codereview.chromium.org/197473004/diff/1/src/heap.cc#newcode5048
src/heap.cc:5048:
HeapObject::cast(obj)->set_map_no_write_barrier(fixed_array_map());
Can you set fixed_cow_array_map() here?
https://codereview.chromium.org/197473004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/197473004/diff/1/src/hydrogen.cc#newcode9776
src/hydrogen.cc:9776:
This method needs more comments... please explain what is going on here.
https://codereview.chromium.org/197473004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
