Nice cleanup! Just one comment.
https://codereview.chromium.org/197283017/diff/1/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/197283017/diff/1/src/ic.cc#newcode1372
src/ic.cc:1372: isolate(), global, cell);
Nice catch!
On 2014/03/14 16:15:59, ulan wrote:
Passing raw pointers was a bug as GetCodeCopyFromTemplate allocates.
https://codereview.chromium.org/197283017/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/197283017/diff/1/src/objects.cc#newcode10521
src/objects.cc:10521: }
Why don't we just introduce an invariant that the objects in the pattern
are required to be in the right order? That way we don't have this
O(m*n) algo, but just O(m).
Then add a second invariant that all objects in the pattern are required
to be used.
https://codereview.chromium.org/197283017/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
