Thanks for the look Hannes, addressed comments.
--Michael
https://codereview.chromium.org/197473004/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/197473004/diff/1/src/heap.cc#newcode5042
src/heap.cc:5042: ASSERT(InNewSpace(src));
On 2014/03/17 09:37:18, Hannes Payer wrote:
This ASSERT may be wrong here, but it should hold in factory.cc.
This is what can happen: The factory may trigger a gc which may move
src to old
space.
In that case, you could just return the old src instead of allocating
a new one.
WDYT?
Great idea, thx, done.
https://codereview.chromium.org/197473004/diff/1/src/heap.cc#newcode5048
src/heap.cc:5048:
HeapObject::cast(obj)->set_map_no_write_barrier(fixed_array_map());
On 2014/03/17 09:37:18, Hannes Payer wrote:
Can you set fixed_cow_array_map() here?
No because of protections in FixedArray::set() against setting elements
in a COW array. Created issue v8:3221 to track an alternate approach,
that of pretenuring all boilerplates, allowing us to remove this
approach completely.
Also added a comment to that effect.
https://codereview.chromium.org/197473004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/197473004/diff/1/src/hydrogen.cc#newcode9776
src/hydrogen.cc:9776:
On 2014/03/17 09:37:18, Hannes Payer wrote:
This method needs more comments... please explain what is going on
here.
Done.
https://codereview.chromium.org/197473004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
