some comments.
https://codereview.chromium.org/206073007/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/206073007/diff/1/src/builtins.cc#newcode980
src/builtins.cc:980: accessor->CopyElements(
I should have noticed this in an earlier CL. Why do we no longer check
(assert) whether CopyElements failed? Could we add an assertion in
CopyElements itself?
https://codereview.chromium.org/206073007/diff/1/src/factory.h
File src/factory.h (right):
https://codereview.chromium.org/206073007/diff/1/src/factory.h#newcode367
src/factory.h:367: return NewJSArray(elements_kind, 0, capacity,
pretenure);
Do we really need this wrapper?
https://codereview.chromium.org/206073007/diff/1/src/factory.h#newcode374
src/factory.h:374: PretenureFlag pretenure = NOT_TENURED);
Same here.
https://codereview.chromium.org/206073007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
