https://codereview.chromium.org/206073007/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/206073007/diff/1/src/builtins.cc#newcode980
src/builtins.cc:980: accessor->CopyElements(
On 2014/03/20 15:21:41, Yang wrote:
I should have noticed this in an earlier CL. Why do we no longer check
(assert)
whether CopyElements failed? Could we add an assertion in CopyElements
itself?
Done.
https://codereview.chromium.org/206073007/diff/1/src/factory.h
File src/factory.h (right):
https://codereview.chromium.org/206073007/diff/1/src/factory.h#newcode367
src/factory.h:367: return NewJSArray(elements_kind, 0, capacity,
pretenure);
On 2014/03/20 15:21:41, Yang wrote:
Do we really need this wrapper?
The NewJSArray() without length was here for some time and already has a
number of usages. But in my case I needed a more general one having both
length and capacity parameters. So I added it (see above) and defined
the old one as a special case of a new one.
https://codereview.chromium.org/206073007/diff/1/src/factory.h#newcode374
src/factory.h:374: PretenureFlag pretenure = NOT_TENURED);
On 2014/03/20 15:21:41, Yang wrote:
Same here.
Same here for NewJSArrayWithElements(). To make this relationship more
explicit I'll move the implementation of the specific case to the
header.
https://codereview.chromium.org/206073007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
