On 2014/03/24 14:04:02, Yang wrote:
Goes in the right direction, but I got some suggestions.
https://codereview.chromium.org/209353006/diff/10001/src/runtime.h
File src/runtime.h (left):
https://codereview.chromium.org/209353006/diff/10001/src/runtime.h#oldcode649
src/runtime.h:649: #define INLINE_RUNTIME_FUNCTION_LIST(F) \
Entries in this list are expanded to kFoo and kInlineFoo. There is no
need to
remove this list and add duplicates called kFooInternal to
RUNTIME_FUNCTION_LIST
and rename all the uses.
How about keeping this list, and put functions that in their inline
version
only
call the runtime version into the new INLINE_OPTIMIZED_FUNCTION_LIST?
If you insist in calling them kFooInternal, I suggest using the macro to
expand
the definitions instead of adding those duplicates all over
RUNTIME_FUNCTION_LIST.
I am not sure I follow you here: kFooInternal are very different from
k(Inline)Foo.
We should not mix them.
Either way, I suggest adding another intrinsic type (RUNTIME_INTERNAL or
RUNTIME_HIDDEN) for those runtime functions that are not supposed to be
called
directly and only act as slow case for %_Foo and make sure they are not
callable
through %Foo from anywhere.
This is a good idea - will do.
https://codereview.chromium.org/209353006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
