LGTM if comments addressed.
It would be nice to have a test ensuring we cannot call %HiddenFoo.
https://codereview.chromium.org/209353006/diff/30001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/209353006/diff/30001/src/ia32/full-codegen-ia32.cc#newcode4147
src/ia32/full-codegen-ia32.cc:4147: expr->function()->intrinsic_type ==
Runtime::INLINE ) {
stray white space after Runtime::INLINE.
https://codereview.chromium.org/209353006/diff/30001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/209353006/diff/30001/src/runtime.cc#newcode14604
src/runtime.cc:14604: // Exclude the code in release mode.
Would be nice to update this as well.
https://codereview.chromium.org/209353006/diff/30001/src/runtime.h
File src/runtime.h (right):
https://codereview.chromium.org/209353006/diff/30001/src/runtime.h#newcode605
src/runtime.h:605: // RUNTIME_HIDDEN_FUNCTION_LIST defined all runtime
functions accessed
s/defined/defines/
https://codereview.chromium.org/209353006/diff/30001/test/mjsunit/fuzz-natives-part1.js
File test/mjsunit/fuzz-natives-part1.js (right):
https://codereview.chromium.org/209353006/diff/30001/test/mjsunit/fuzz-natives-part1.js#newcode164
test/mjsunit/fuzz-natives-part1.js:164: "LogInternal": true,
Outdated name? Do we even need this line? We should add all hidden
runtime functions to %ListNatives, and make sure that calling them in
this test will not crash (simply throws in an eval).
https://codereview.chromium.org/209353006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
