https://codereview.chromium.org/212893007/diff/20001/include/v8-util.h
File include/v8-util.h (right):
https://codereview.chromium.org/212893007/diff/20001/include/v8-util.h#newcode256
include/v8-util.h:256: explicit
PersistentValueReference(PersistentContainerValue value)
expose copy constructor
https://codereview.chromium.org/212893007/diff/20001/include/v8-util.h#newcode263
include/v8-util.h:263: * Helper for V8ValueCache: Get a reference to a
map value.
don't mention v8valuecache
https://codereview.chromium.org/212893007/diff/20001/include/v8-util.h#newcode267
include/v8-util.h:267: * Careful: This is potentially unsafe, in that
*any* change to the
there are limited actions that invalidates these : calling Set or Remove
with the same key, the weak callback for the key, and Clear()
mention them explicitly
https://codereview.chromium.org/212893007/diff/20001/include/v8-util.h#newcode283
include/v8-util.h:283: V8_INLINE PersistentValueReference
SetWithReference(
no need for this function since it calls just Set followed by Get
we could instead have a function
UniquePersistent Set(key, value, ValueReference*)
that does all the work of regular Set but sets the valuereference before
the actual call to Set
https://codereview.chromium.org/212893007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
