https://codereview.chromium.org/212893007/diff/20001/include/v8-util.h
File include/v8-util.h (right):
https://codereview.chromium.org/212893007/diff/20001/include/v8-util.h#newcode256
include/v8-util.h:256: explicit
PersistentValueReference(PersistentContainerValue value)
On 2014/03/27 07:45:22, dcarney wrote:
expose copy constructor
Done.
https://codereview.chromium.org/212893007/diff/20001/include/v8-util.h#newcode263
include/v8-util.h:263: * Helper for V8ValueCache: Get a reference to a
map value.
On 2014/03/27 07:45:22, dcarney wrote:
don't mention v8valuecache
Done.
https://codereview.chromium.org/212893007/diff/20001/include/v8-util.h#newcode267
include/v8-util.h:267: * Careful: This is potentially unsafe, in that
*any* change to the
On 2014/03/27 07:45:22, dcarney wrote:
there are limited actions that invalidates these : calling Set or
Remove with
the same key, the weak callback for the key, and Clear()
mention them explicitly
Done.
I'm not entirely convinced of it, though: This is the type of comment
that has a high chance of becoming stale/incorrect, in that changes to
the Map may invalidate the given list of specific functions. Since this
comment isn't located where those changes would happen, the chance that
the comment gets updated is rather slim. Hence my preference for a stern
but somewhat unspecific warning.
https://codereview.chromium.org/212893007/diff/20001/include/v8-util.h#newcode283
include/v8-util.h:283: V8_INLINE PersistentValueReference
SetWithReference(
On 2014/03/27 07:45:22, dcarney wrote:
no need for this function since it calls just Set followed by Get
Removed.
we could instead have a function
UniquePersistent Set(key, value, ValueReference*)
that does all the work of regular Set but sets the valuereference
before the
actual call to Set
Done. Added tests.
https://codereview.chromium.org/212893007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
