https://codereview.chromium.org/202293004/diff/50001/src/close-table.h
File src/close-table.h (right):
https://codereview.chromium.org/202293004/diff/50001/src/close-table.h#newcode77
src/close-table.h:77: return kHashTableStartIndex +
Smi::cast(get(kNumberOfBucketsIndex))->value();
This can be
return kHashTableStartIndex + NumberOfBuckets();
https://codereview.chromium.org/202293004/diff/50001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/202293004/diff/50001/src/objects.cc#newcode15946
src/objects.cc:15946: new_table->set(index, key);
For map, we probably need to store the value at index+1
The loop should probably be entry += entrysize and
then an inner loop from entry to entry+entrysize to copy over key,
values and magical third item of a pair.
https://codereview.chromium.org/202293004/diff/50001/src/objects.cc#newcode15961
src/objects.cc:15961: if (!bucket_entry->IsSmi()) return kNotFound;
Maybe we should use -1 instead of undefined? Might be faster
https://codereview.chromium.org/202293004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
