Reviewers: arv,
https://codereview.chromium.org/202293004/diff/50001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/202293004/diff/50001/src/objects.cc#newcode15946
src/objects.cc:15946: new_table->set(index, key);
On 2014/03/27 22:39:02, arv wrote:
For map, we probably need to store the value at index+1
The loop should probably be entry += entrysize and
then an inner loop from entry to entry+entrysize to copy over key,
values and
magical third item of a pair.
Oh, you're looking at an old one. This is now an inner for loop.
https://codereview.chromium.org/202293004/diff/50001/src/objects.cc#newcode15961
src/objects.cc:15961: if (!bucket_entry->IsSmi()) return kNotFound;
On 2014/03/27 22:39:02, arv wrote:
Maybe we should use -1 instead of undefined? Might be faster
Hmm, and I guess I can use -1 even in the chain...sounds like a
reasonable plan. I still need to add code to fill up the data table with
the_hole_value, though, since I'm using that as a sentinel now in my
Rehash loop.
Description:
Work in progress: ES6 Maps and Sets with deterministic iteration support
Please review this at https://codereview.chromium.org/202293004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+346, -0 lines):
A src/close-table.h
M src/factory.h
M src/factory.cc
M src/objects.cc
M test/cctest/cctest.gyp
A test/cctest/test-closemap.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
