Logically, I think LeftTrimFixedArray and RightTrimFixedArray should be part of
FixedArrayBase. But they shouldn't access GC internals from there. You could
make TrimObjectStart and TrimObjectEnd helper methods which are in heap and they take care of free space filler creation, mark bits, live bytes count, and maybe also heap profiler (depending how general they should be - the more general the
better). These helpers can be called from other places in object.cc as well,
i.e. all places that call CreateFillerObjectAt, which would result in a larger
dependency cleanup. WDYT?

https://codereview.chromium.org/200443004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to