On 2014/04/01 13:45:10, danno-g wrote:
Hmm. I am not sure I agree, Hannes. Why should they be in FixedArray? The
trimming contains lots of implementation details of the GC, so that
doesn't
belong in object.* or FixedArray, IMO, it belongs in the GC, which
subscribes
to
the minimum of information from objects.h/FixedArrayBase to get it's job
done.
Litmus test: If you replaced our current GC with a different one, which
files
would you intuitively think you have to change? object.* or heap.cc? Seems
like
heap.cc to me.
I am not saying they should be part of object.*. I am saying that the actual
FixedArray
specific code should be in object.* and the garbage collector related code
should be
in an abstract Trim* method in heap.*.
https://codereview.chromium.org/200443004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
