https://codereview.chromium.org/202293004/diff/160001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/202293004/diff/160001/src/objects.cc#newcode15903
src/objects.cc:15903: capacity = Max(kMinCapacity, capacity);
On 2014/03/29 02:26:07, arv wrote:
Can be an assert instead? I don't think this needs to be a runtime
check.
Something like that, yeah. I'm sort of waiting till the callers shake
out to fix the API of Allocate (and Factory::New*)
https://codereview.chromium.org/202293004/diff/160001/src/objects.cc#newcode15929
src/objects.cc:15929: // Don't need to grow if we can simply clear out
deleted entries instead.
On 2014/03/29 02:26:07, arv wrote:
This comment does not look accurate. We still call Allocate.
We should probably add a Compact function that does the in place
cleanup.
The comment is confusing, I admit. It's trying to explain the ternary
operator on the next line, which doubles capacity unless keeping the
same capacity (but a new backing store) would work, due to deletions.
I don't believe this data structure supports in-place rehashing, since
collapsing chains can break the ordering. But perhaps you have something
clever in mind?
https://codereview.chromium.org/202293004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
