Generally looks good to me, one question and adding JFB since he had some
comments on the implementation in Chromium/Base.
https://codereview.chromium.org/220793002/diff/1/src/atomicops_internals_arm64_gcc.h
File src/atomicops_internals_arm64_gcc.h (right):
https://codereview.chromium.org/220793002/diff/1/src/atomicops_internals_arm64_gcc.h#newcode57
src/atomicops_internals_arm64_gcc.h:57: : [old_value]"IJr" (old_value),
Do the I and J constraints require that the value fit in an immediate
(12 bits) or is it just a hint that an immediate should be used if it
does fit?
https://codereview.chromium.org/220793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
