On 2014/04/01 16:08:09, JF wrote:
I'm not sure I understand why "memory" is kept in some places and removed
in
others.
lgtm otherwise.
From http://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html :
If your assembler instructions access memory in an unpredictable fashion,
add
'memory' to the list of clobbered registers. This causes GCC to not keep
memory
values cached in registers across the assembler instruction and not optimize
stores or loads to that memory. You also should add the volatile keyword if
the
memory affected is not listed in the inputs or outputs of the asm, as the
'memory' clobber does not count as a side-effect of the asm.
So memory is needed when we have barriers, but not when we use 'simple'
load/store instructions.
https://codereview.chromium.org/220793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
